Re: strncpy() and NULL termination

Another thing I've noticed is some bits of source pass argv[] values directly, eg this evil bit from domainname.c :

if (*argv) {
  if (setdomainname(*argv, strlen(*argv))     err(1, "setdomainname");
} else {
 ...

Passing argv like this is evil, and a check SHOULD be made before passing something like this to a function. FYI the library call does the argument length checking, but if it was calling something that didn't do range checking.. maybe suid/sgid?

Cya.

--
Adrian Chadd			|	Windows 95 - the XT emulator for
		|	 your 486 and above!
				|	Being superstitious is bad luck.