Re: does this alias exist??

From: Aaron Bornstein <aaronb(at)j51.com>
Date: Sat Feb 15 1997 - 21:26:28 EST

On Sun, 16 Feb 1997, Mark Huizer wrote:

> Well, just testing if three ppl are on here, as it should be
> (xaa,ab,ee)...
> 
	Ok, let's recap for ee.  I've found a few bugs, Mark's written a 

couple of patches. I'm in the process of writing patches at the moment... here's a preliminary patch for battlestar. There's three bugs here, two overflows and a race condition. I'm not sure if I handled the race condition in the most elegant manner, comments appreciated.

• battlestar/externs.h.old Sat Feb 15 21:08:20 1997
  +++ battlestar/externs.h Sat Feb 15 21:06:43 1997
  @@ -248,11 +248,11 @@ char *getcom(), *getword();

        /* state of the game */
-int time;
+int gtime;

 int position;
 int direction;
 int left, right, ahead, back;
-int clock, fuel, torps;
+int gclock, fuel, torps;

 int carrying, encumber;
 int rythmn;
 int followfight;

• battlestar/save.c.old Sat Feb 15 16:50:39 1997
  +++ battlestar/save.c Sat Feb 15 21:07:19 1997
  @@ -35,27 +35,33 @@ static char sccsid[] = "@(#)save.c 8.1 (Berkeley) 5/31/93"; #endif /* not lint */

+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/param.h> /* MAXPATHLEN */
+#include <fcntl.h>

 #include "externs.h"  

+void

 restore()
 {

        char *getenv();
        char *home;
-       char home1[100];


+       char home1[MAXPATHLEN];


        register int n;
        int tmp;
        register FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");

+       if ( (home = getenv("HOME")) != NULL) 

+         sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);

+       else return;

+

        if ((fp = fopen(home1, "r")) == 0) {
                perror(home1);
                return;
        }
        fread(&WEIGHT, sizeof WEIGHT, 1, fp);
        fread(&CUMBER, sizeof CUMBER, 1, fp);
-       fread(&clock, sizeof clock, 1, fp);


+       fread(&gclock, sizeof gclock, 1, fp);


        fread(&tmp, sizeof tmp, 1, fp);
        location = tmp ? dayfile : nightfile;
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -68,7 +74,7 @@
        fread(notes, sizeof notes, 1, fp);
        fread(&direction, sizeof direction, 1, fp);
        fread(&position, sizeof position, 1, fp);
-       fread(&time, sizeof time, 1, fp);


+       fread(>ime, sizeof gtime, 1, fp);


        fread(&fuel, sizeof fuel, 1, fp);
        fread(&torps, sizeof torps, 1, fp);
        fread(&carrying, sizeof carrying, 1, fp);
@@ -90,26 +96,51 @@
        fread(&ego, sizeof ego, 1, fp);

 }  

+void

 save()
 {
+ struct stat sbuf;

        char *getenv();
        char *home;
-       char home1[100];


+       char home1[MAXPATHLEN];


        register int n;
-       int tmp;


+       int tmp, fd;


        FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");
-       if ((fp = fopen(home1, "w")) == 0) {

+       if ( (home = getenv("HOME")) != NULL) 

+               sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);

+       else 

+               return;

+

+       /* Try to open the file safely. */

+       if ( (stat(home1, &sbuf)) < 0) {                

+               fd = open(home1, O_WRONLY|O_CREAT|O_EXCL);

+               if (fd < 0) {

+                       fprintf(stderr, "Can't create %s\n", home1);

+                       return;

+               }

+       } else {

+               if (sbuf.st_nlink > 1) {

+                       fprintf(stderr, "No symlinks!\n");

+                       return;

+               }

+

+               fd = open(home1, O_WRONLY|O_EXCL);

+               if (fd < 0) {

+                       fprintf(stderr, "Can't open %s for writing\n", home1);

+                       return;

+               }

+       }

+

+       if ((fp = fdopen(fd, "w")) == 0) {


                perror(home1);
                return;
        }

+

        printf("Saved in %s.\n", home1);
        fwrite(&WEIGHT, sizeof WEIGHT, 1, fp);
        fwrite(&CUMBER, sizeof CUMBER, 1, fp);
Do you need help?
In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software:
Learn more about Pantek's Technical Support offerings
Place an order for 24/7/365 Technical Support here
Learn more about Pantek, who we are, and what we do
Chat with a Live Operator
Related audit-dead Links
auditors
bin
contrib
eBones
games
init
lib
libc
libexec
lkm
sbin
secure
telnetd
usr
Request more information about Pantek
-       fwrite(&clock, sizeof clock, 1, fp);


+       fwrite(&gclock, sizeof gclock, 1, fp);


        tmp = location == dayfile;
        fwrite(&tmp, sizeof tmp, 1, fp);
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -122,7 +153,7 @@
        fwrite(notes, sizeof notes, 1, fp);
        fwrite(&direction, sizeof direction, 1, fp);
        fwrite(&position, sizeof position, 1, fp);
-       fwrite(&time, sizeof time, 1, fp);


+       fwrite(>ime, sizeof gtime, 1, fp);


        fwrite(&fuel, sizeof fuel, 1, fp);
        fwrite(&torps, sizeof torps, 1, fp);
        fwrite(&carrying, sizeof carrying, 1, fp);
@@ -142,4 +173,5 @@
        fwrite(&pleasure, sizeof pleasure, 1, fp);
        fwrite(&power, sizeof power, 1, fp);
        fwrite(&ego, sizeof ego, 1, fp);

+

 } Received on Sat Feb 15 18:26:23 1997