Hosting Provided By

DO NOT REPLY [Bug 14147] - patch for filename truncation bug in ap_directory_walk

From: <bugzilla(at)apache.org>
Date: Thu Oct 31 2002 - 16:05:50 EST

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14147>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14147

patch for filename truncation bug in ap_directory_walk

Additional Comments From trawick@apache.org 2002-10-31 21:05 ------- That looks good. I suspect that wrowe needs to bless it before committing it though.

The check below always succeeds, right?

--> if (r->filename[filename_len-1] == '/')

I suspect that it should probably be

AP_DEBUG_ASSERT(r->filename[filename_len-1] == '/'); r->filename[--filename_len] = '\0';

The AP_DEBUG_ASSERT() is a good way to doc the assumption but it won't generate any code unless you build with
--enable-maintainer-mode.

Thanks for digging into this!!!!!

To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org For additional commands, e-mail: bugs-help@httpd.apache.org Received on Thu Oct 31 21:04:53 2002

Do you need help?

This message: [ Message body ]
Next message: bugzilla(at)apache.org: "DO NOT REPLY [Bug 14093] - ap_log_rerror and ap_log_error enhancements"
Previous message: bugzilla(at)apache.org: "DO NOT REPLY [Bug 10236] - MOVE method loses last character off of file name"
In reply to bugzilla(at)apache.org: "DO NOT REPLY [Bug 14147] New: - patch for filename truncation bug in ap_directory_walk"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]

This archive was generated by hypermail 2.1.8 : Wed Aug 23 2006 - 16:44:01 EDT