mod_proxy and empty headers

From: Christian von Roques <roques(at)mti.ag>
Date: Fri Mar 09 2001 - 15:14:18 EST

Empty headers are allowed by RFC2068 section 4.2. The presence or absence of an empty header can be significant. The current mod_proxy of httpd 1.3.x removes empty headers. The patch below, relative to V1.3.20dev of today changes mod_proxy to preserve empty headers.

Is there a reason why mod_proxy should remove empty headers?

        Christian.

diff -X nodiff.pats -crd apache/src/modules/proxy/proxy_util.c apache+proxy_empty_header/src/modules/proxy/proxy_util.c

*** apache/src/modules/proxy/proxy_util.c	Wed Feb  7 17:05:14 2001
--- apache+proxy_empty_header/src/modules/proxy/proxy_util.c	Fri Mar  9 15:54:20 2001

---

• 1267,1274 ****
  {
  struct tbl_do_args *parm = (struct tbl_do_args *)p;

!     if (key == NULL || value == NULL || value[0] == '\0')
  	return 1;
      if (!parm->req->assbackwards)
  	ap_rvputs(parm->req, key, ": ", value, CRLF, NULL);
      if (parm->cache != NULL && parm->cache->fp != NULL &&

--- 1267,1276 ----
{

      struct tbl_do_args *parm = (struct tbl_do_args *)p;   

!     if (key == NULL)
  	return 1;
+     if (value == NULL)
+ 	value = "";
      if (!parm->req->assbackwards)
  	ap_rvputs(parm->req, key, ": ", value, CRLF, NULL);
      if (parm->cache != NULL && parm->cache->fp != NULL &&

Received on Fri Mar 09 20:14:43 2001