Bug#460105: /etc/init.d/apache2 greps excessively for PidFile

Package: Apache2
Version: 2.2.6-3
User: nvalcarcel@ubuntu-pe.org
Usertags: origin-ubuntu hardy ubuntu-patch

/etc/init.d/apache2 does a "grep ^PidFile /etc/apache2/* -r".

this grep has two (and others) main disadvantages: 1. It reads an unkown number of files without reason (remember: a dedicated host might have hundreds of files and symlinks in sites-enabled|sites-available.
2. It would even parse a file like apache.conf.backup and check if there is a pid to kill.

Therefore I'd only parse .conf files or better apache2.conf as this is the place to configure the location of the PidFile. Besides this would solve the mentioned problem.

Or ideally being more intelligent about which files to look at, e.g. *.conf...
Originaly reported on:
https://bugs.edge.launchpad.net/ubuntu/+source/apache2/+bug/112991

Attaching patch who solves it

-- 
aka nxvl
Peruvian LoCo Team
Key fingerprint = 8104 21CE A580 7EB7 5184  8DFF 6A3A D5DA 24DC 6AF5
gpg --keyserver keyserver.ubuntu.com --recv-keys 24DC6AF5

-- To UNSUBSCRIBE, email to debian-apache-REQUEST@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.debian.org Links debian-announce debian-apache debian-arm-changes debian-beowulf debian-boot debian-cd debian-cd-vendors debian-changes debian-changes-digest debian-isp debian-kde debian-laptop debian-mirrors-announce debian-news debian-security debian-security-announce debian-testing debian-user debian-user-digest Request more information about Pantek