Re: [PATCH] partman mount.d scripts and mount options

On Mon, Jul 02, 2007 at 11:34:10PM +0300, Anton Zinoviev wrote:
> On Mon, Jul 02, 2007 at 06:43:19PM +0100, Colin Watson wrote:
> > * Removed "-o $options" for the mount-command in mount.d/basic.
> > Otherwise the ro flag would mount read-only...
> >
> > I can't think of any other flags that might be harmful during
> > installation. What do folks think about the attached patch?
>
> Yes, I like the method used in this patch. I suppose in order to be
> safe, in finish.d/mount_partitions I would permit only the loop option
> (because I wouldn't have to watch if some change in the options of
> some file system becomes dangerous), but your method also has its
> pluses.

I just tried to implement that to see how it felt, and discovered I couldn't do it as elegantly in sh (you can't use ${...%%...} to strip something like "loop=blah" when you don't know what blah is), which always tends to affect my judgement. ;-)

Actually, the problem is not all that bad, as the only options you can use are those explicitly listed in */mountoptions/*, so there isn't very much to check. All the other existing mount options appear to be safe, so I've gone with my approach for now and we can revisit it later if it proves to be problematic.

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]


-- 
To UNSUBSCRIBE, email to debian-boot-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org