Pantek Library
Hosting Provided By
CybrHost
High Speed Hosting
Mailing Lists: lists.debian.org > debian-boot > 07 > 102647.html (Request Expert lists.debian.org Support)

[RFC] Support column alignment in (multi)select debconf questions

From: Jérémy Bobbio <lunar(at)debian.org>
Date: Sat Oct 13 2007 - 20:38:24 EDT


Hi!

Attached is a patch adding a new capability to cdebconf named "align", following Anton's proposal [1] and as discussed during the september IRC meeting [2]. 

 cdebconf/src/commands.c                                 |    5 
 cdebconf/src/frontend.c                                 |    6 
 cdebconf/src/frontend.h                                 |    2 
 cdebconf/src/modules/frontend/gtk/Makefile              |    4 
 cdebconf/src/modules/frontend/gtk/align_text_renderer.c |  284 ++++++++++++++++
 cdebconf/src/modules/frontend/gtk/align_text_renderer.h |   87 ++++
 cdebconf/src/modules/frontend/gtk/cdebconf_gtk.c        |    7 
 cdebconf/src/modules/frontend/gtk/cdebconf_gtk.h        |    7 
 cdebconf/src/modules/frontend/gtk/select_handlers.c     |  121 +++++-
 cdebconf/src/modules/frontend/gtk/ui.c                  |   19 +
 cdebconf/src/modules/frontend/gtk/ui.h                  |    2 
 cdebconf/src/modules/frontend/newt/newt.c               |   15 
 cdebconf/src/modules/frontend/text/text.c               |   37 --
 cdebconf/src/strutl.c                                   |   95 +++++
 cdebconf/src/strutl.h                                   |    3 
 cdebconf/src/test/align.config                          |   16 
 cdebconf/src/test/align.templates                       |   11 
 localechooser/debian/control                            |    2 
 localechooser/localechooser                             |    4 
 localechooser/mktemplates.language                      |    3
 20 files changed, 682 insertions(+), 48 deletions(-)

This capability has been implemented in the three main frontends (namely text, newt and gtk) that are currently used in cdebconf.

The current implementation differs from Anton's first proposal in two ways:

  • There is no column titles: it was quite hard to implement, and after some review of the current d-i templates, they seemed not really needed to me.
  • The \t (TAB) character is the column separator.

This last point raised some concerns for Otavio as tabs might be more difficult to spot while reviewing templates. Christian confirmed my feeling that it was a good idea though, as he told me that it was totally unused in our templates and that we need to add comments before those templates in any cases.

The patch also contains a small change to localechooser to make it benefits from the new capability. The next best candidate is probably partman, and Anton told me that he would try to have a look in the next days.

I wonder if those changes should be pushed in beta1. I have a good feeling about them and that would be a first real improvement to show up in the graphical installer since Etch. But, please, review and test first! :)

[1] http://lists.debian.org/debian-boot/2007/07/msg00723.html [2] http://people.debian.org/~lunar/d-i/irc-meeting-20070926/minutes

Do you need help?X

Cheers, 

-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :â’¶  :  # apt-get install anarchism
                                    `. `'` 
                                      `-

-- To UNSUBSCRIBE, email to debian-boot-REQUEST@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Received on Sat Oct 13 20:40:52 2007

This archive was generated by hypermail 2.1.8 : Wed Mar 19 2008 - 03:04:13 EDT

Contact Us  Legal Notices  Order Services Online 
Pantek Home  Privacy Policy  IT news  Site Map  Pantek Library