Hosting Provided By

Re: [RFC] Erase LVM/crypto issues and proposed partman reorg

From: Frans Pop <elendil(at)planet.nl>
Date: Tue Dec 04 2007 - 10:39:38 EST

On Tuesday 04 December 2007, Max Vozeler wrote:
> David's changes include good code that can be reintroduced
> later on to a large extent [...]

Yes, absolutely. Same goes for the changes suggested by Jérémy.

I have committed the revert.

> > 1) Rename current "wipe" functions
> >
> > For partman-crypto I have a patch that renames the existing functions
> > to include the crypto namespace:
> > - wipe -> crypto_do_wipe
> > - dev_wipe -> crypto_wipe_device
>
> Good change, agreed. In fact I have a patch sitting here
> that does the exact same change, among others.

OK. Attached my version of the patch that also includes some other minor cleanups. Let me know if I should commit this or that you want to commit your own version. However, I will commit my version before I start on the reorganization (see below).

> I'm willing to put in some work to help deal with the
> implementation and fallout of this and the other proposed
> changes, (and eventually contribute to the reimplementation
> of the removal of crypto devices). I'm happy to set aside
> some time this weekend and review or test changes.

That's great. I don't expect much fallout, but some extra testing is always welcome. And help with the re-implementation is especially welcome.

I will start work on this tomorrow. If anybody has any pending changes for partman (that are solid enough), please commit them before then.

Do you need help?

-- 
To UNSUBSCRIBE, email to debian-boot-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


text/x-diff attachment: partman-crypto.patch



application/pgp-signature attachment: This is a digitally signed message part.

Received on Tue Dec 4 10:44:29 2007

This message: [ Message body ]
Next message: Frans Pop: "Re: Refactoring commit_changes in partman"
Previous message: Frans Pop: "Bug#453749: simpler solution"
In reply to: Max Vozeler: "Re: [RFC] Erase LVM/crypto issues and proposed partman reorg"
Next in thread: Max Vozeler: "Re: [RFC] Erase LVM/crypto issues and proposed partman reorg"
Reply: Max Vozeler: "Re: [RFC] Erase LVM/crypto issues and proposed partman reorg"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]

This archive was generated by hypermail 2.1.8 : Wed Mar 19 2008 - 03:36:54 EDT