Re: [RFC] laptop-detect being installed just on useful architectures

Frans Pop <elendil@planet.nl> writes:

> On Friday 08 February 2008, Otavio Salvador wrote:
>> I plan to commit this cuple of packages tomorrow, if noone objects, to
>> address the laptop-detect issue.
>>
>> This changes laptop-detect from a dependency, on tasksel, to a
>> recommendation and let d-i to install it. This way we avoid the
>> changing of tasksel to architecture dependent package and solves the
>> problem of getting laptop-detect installed on every arch.
>
> 1) You did not answer my question whether laptop-detect really supports
> sparc. If it does not, we should not install it there (and laptop-detect
> should not be built for sparc).

It does, if kernel does.

Currently laptop-detect checks dmi and if there're batteries[1] on the system, in those cases, it guess it's a laptop.

1. http://git.debian.org/?p=collab-maint/laptop-detect.git;a=blob;f=laptop-detect.in

> 2) I think the log message for non-laptop arches is redundant.

Yes, I think it makes sense to remove it.

> 3) The laptop test in tasksel should be modified to _first_ test whether
> laptop-detect exists or not. As it is now it will barf errors.

I found it in two places and changed both them.

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.debian.org Links debian-announce debian-apache debian-arm-changes debian-beowulf debian-boot debian-cd debian-cd-vendors debian-changes debian-changes-digest debian-isp debian-kde debian-laptop debian-mirrors-announce debian-news debian-security debian-security-announce debian-testing debian-user debian-user-digest Request more information about Pantek

New patches attached.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: 
http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



-- 
To UNSUBSCRIBE, email to debian-boot-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


text/x-diff attachment: stored



text/x-diff attachment: stored