Re: Use of VERBOSE in debian-cd

"Bruce Korb" <bruce.korb@gmail.com> writes:

> Hi all,
>
> The debian-cd scripts are not necessarily run by hand.
> A higher level script may be driving. That, in turn, may
> be driven by yet another layer of scripting. (In fact, that's
> what I'm doing now.) Unfortunately, one cannot know that
> a hierarchy of scripts used by some scripts that are being
> used by my scripts are going to be unable to cope with
> a non-numeric value in the environment variable, VERBOSE.
> I got error messages from "list2cd" because VERBOSE was
> set to "true". Please consider being careful:
>
> my $verbose = $ENV{VERBOSE} || 0;
> if ($verbose !~ m/^\d+$/) {
> $verbose = 0;
> }

Personally I don't like this change since all the other vars has same usage and then we would need to validate all of them.

All debian-cd uses 0 and 1 for false and true.

About the proposed change, you forgot to quote VERBOSE a as 'VERBOSE'.

My 2c

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: 
http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."


-- 
To UNSUBSCRIBE, email to debian-cd-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org