Re: linux-ipsec: Patches for the Alpha.

On 08-Dec-98 Richard Guy Briggs wrote:
> -----BEGIN PGP SIGNED MESSAGE-----

>> I'm about ready to produce the patches from my DEC Alpha porting work.

Its taken a bit longer that I expected as I decided to tidy up all the compiler warnings that come from all the dubious casts in many of the DEBUG printks...

Also I think this may be a bug...

pluto/kernel.c/setup_ipsec_sa near the very end

fail:

    {

        /* undo the done SPIs */
        while (r_said_next-- != r_said)
            (void) del_spi(fd, (u_char *)r_said_next->spi,
r_said_next->proto
                , c->this.host);

        while (s_said_next-- != s_said)
            (void) del_spi(fd, (u_char *)s_said_next->spi, s_said_next->proto
                , c->that.host);
        return FALSE;

The compiler complains about the "(u_char *)" casts. "r_said_next->spi" is an "ipsec_spi_t" which is an "u_int32_t", and del_spi wants a "const u_char spi[IPSEC_DOI_SPI_SIZE]" as its paramemter which is the same as "const u_char *spi" ( I looked in K&R just to make sure :-) )   

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.freeswan.org Links 1998-fall 1998-spring 1998-summer 1998-winter 1999-winter announce briefs bugs design freeswan-list hipsec ietf-sectest users users-admin Request more information about Pantek

Well IPSEC_DOI_SPI_SIZE is 4, so alteast its the same as a u_int32_t, but I think there is a missing "&" eg I think it should be ....

(u_char *) &r_said_next->spi

which the compiler is happy about....

Before I release the patches I need to check that my changes haven't created any problems when built on an Intel box...

Another couple of things...

I've used libdes-4.04b.tar.gz from Eric A Young as this newer version needed little work to get it right on the Alpha and required only minimal changes to the make files... it untars into a directory called des, so just rename it to libdes and all is OK. I'll check that nothing more needes to be done before I post my patches.

ftp://ftp.psy.uq.oz.au/pub/Crypto/DES/libdes-4.04b.tar.gz

The gmp libraries need to be configured for the Alpha before you run make for the first time.. This needs to me mentioned in the INSTALL file.

Do you need more help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.freeswan.org Links 1998-fall 1998-spring 1998-summer 1998-winter 1999-winter announce briefs bugs design freeswan-list hipsec ietf-sectest users users-admin Request more information about Pantek

Can't think of anything else right now.....

Peter Onion.

This message was sent by XFMail