Re: linux-ipsec: Bug in pluto

| From: Chris the Elder <chippo@cdsec.com>

| I found a small buglet in pluto, a patch is attached.

Thanks! You are right, there is a bug. I'll check the fix in shortly.

Your fix is not quite right: the first argument in the new call of enum_show should be &exchange_desc.

BTW: your diff is backwards. The covention is "diff old new".

Hugh Redelmeier
hugh@mimosa.com voice: +1 416 482-8253

| *** freeswan/pluto/demux.c Wed Jun 17 12:01:38 1998
| --- freeswan-snap1998Jun17/pluto/demux.c Tue Jun 9 05:53:00 1998
| ***************
| *** 378,386 ****
| }
|
| default:
| ! log(0, "out of order packet from %s; expected "
| ! "ISAKMP_XCHG_IDPROT but got %s", show_sa_in(&sin),
| ! enum_show(&payload_desc, hdr.isa_xchg));
| /* XXX Could send notification back */
| free(packet_pbs.start);
| return;
| --- 378,385 ----
| }
|
| default:
| ! log(0, "out of order packet from %s; expected ISAKMP_XCHG_IDPROT but got %s",
| ! show_sa_in(&sin));
| /* XXX Could send notification back */
| free(packet_pbs.start);
| return;
Received on Sat Jun 20 16:09:53 1998