(no subject)

-----BEGIN PGP SIGNED MESSAGE----- Can the manpage of atosubnet be updated which explicitly states that the return values are 0 for success and -1 for failure, when in fact it returns the number of bytes required to write the address. I just spent a couple of hours trying to figure out why eroute has been failing, when in fact it thought it had succeeded (I mucked up one of the strcpy's and didn't regress).

Here is the mod to addrtoa.c:
#if 0

                strcpy(dst, buf);

#else

                for(i = 0; (i < dstlen) && (i < n); i++) {
                        dst[i]=buf[i];
                }

Here is the mod to ultoa.c:
#if 0

                strcpy(dst, p);

#else

                for(i = 0; (i < dstlen) && (i < len); i++) {
                        dst[i]=p[i];
                }

I mucked it up because the variable 'n' was not used consistently between the source modules.

Instead of using #if 0 to eliminate it, perhaps we could use:
#ifndef __KERNEL__

The other change is in datatoa.c:

        case 2:
/*              strcpy(dst, "0"); */
/*              dst += 1; */
                *dst++ = '0';
                *dst = '\0';
                break;
        default:
/*              strcpy(dst, "0x"); */
/*              dst += 2; */
                *dst++ = '0';
                *dst++ = 'x';
                *dst = '\0';
                break;

In some ways, I prefer this, as then nobody will forget to update the 'dst +=' line.

Obviously, the regression tests did not need to have strcpy changed.

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.freeswan.org Links 1998-fall 1998-spring 1998-summer 1998-winter 1999-winter announce briefs bugs design freeswan-list hipsec ietf-sectest users users-admin Request more information about Pantek

I have some stuff to check in...

        slainte mhath, RGB
- --

Richard Guy Briggs -- PGP key available                       Auto-Free Ottawa!
rgb at conscoop dot ottawa dot on dot ca              
http://www.flora.org/afo/http://www.achilles.net/~rgb/                   Ottawa-Rideau Bioregion, Canada

"We left our footprints in the Earth
And punched a hole right through the sky" -- S.Hogarth/J.Helmer(Marillion)

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv

iQCVAwUBNb93Ad+sBuIhFagtAQGePgP/bdVZTSnNaHGVj9Nx1SigRAOl+YznqokJ jTwxonbKrimxoa5N/YM54Do+XqRcLaypiNq4TaaMMl26ijz9gHUZvftFtJqRS2J4 0UGfvdJpsr6c7V2wR3c+O3M1OocTSuQk5/jS+C8lQULT8zl4tCAw2vvTV2ThDDun np0+W+9eOSI=
=eqPl
-----END PGP SIGNATURE----- Received on Wed Jul 29 18:11:29 1998