Re: linux-ipsec: ERROR_MESSAGES: spi invalid key message needs to be better.

> Why can't we have systems where when we get to where this error

Because in this case, there really is little more that can be done. You've fed atodata() something that it couldn't make head or tail of -- unless your computer comes with a telepathy card, there is limited room for improvement in diagnosing this.

I agree that our error messages are pretty cruddy in general, but this one (in the revised version, which makes it clearer just what it doesn't like) cannot be improved very far. At the cost of a changed (and more complex) interface to atodata(), it could be improved slightly, but only slightly. When I've considered this in the past, the small available gain never seemed worth the effort.

                                                          Henry Spencer
                                                       henry@spsystems.net
                                                     (henry@zoo.toronto.edu)