Re: linux-ipsec: Re: Minor bug in ipsec-0.7

Richard Guy Briggs wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
>
> > Hi,I don't care about your minor holes @ bugs, tell someone that interested.

> >
> > There's a little bug in ipsec_tunnel_init in ipsec_tunnel.c on the 0.7
> > release of ipsec.
> >
> > You can't actually get more than an "ipsec" interface.
>
> Yes, I did agonize over this...I realize this will only give one interface,
> but I think it is because it can only be init'ed once. The code was
> originally snarfed from the new_tunnel.c code and upon inspection of this
> and the dummy and a few other modules, I think none of these bits of code
> will create more than one interface without static linking into the kernel.
>
> I should really talk to Alan Cox about that one...but only once I am
> more certain of the issue.
>
> > The code reads:
> >
> > sprintf(dev_ipsec.name,"ipsec%d",ct);
> > while(dev_get(dev_ipsec.name)!=NULL && ct<100) {
> > ct++;
> > }
> >
> > And it should read (i think) :
> >
> > sprintf(dev_ipsec.name,"ipsec%d",ct);
> > while(dev_get(dev_ipsec.name)!=NULL && ct<100) {
> > ct++;
> > sprintf(dev_ipsec.name,"ipsec%d",ct);
> > }
>
> At least, and more...I will get to that problem after device independance
> at which point it will be more useful.
>
> > Regards,
>
> Thanks for your comments.
>
> > Lluis Mora llmora@gibnet.gi
>
> Slainte Mhath, rgb
Received on Fri Feb 6 16:40:29 1998