|
|
| Applications |
| Mailing Lists |
| Miscellaneous |
| Operating Systems |
| Programming |
Re: bk commit - 6.0-falcon tree (istruewing:1.2563) BUG#26827
From: Ingo Strüwing <ingo(at)mysql.com>
Date: Fri Jun 22 2007 - 05:32:59 EDT
>
> In this case you don't need to clone at all. As I wrote above "in
> any case all the above can be skipped if the necessary bit is already
> set". That is, partition handler needs the complete record, so it sets
> all bits in read_set.
Date: Fri Jun 22 2007 - 05:32:59 EDT
Hi Sergei,
Sergei Golubchik wrote:
> Hi!
>
> On Jun 22, Ingo Strüwing wrote:
...
>> The importance of the question is made by the fact that we need to do >> the same in the partition handler when an update moves a record from >> one partition to another. ha_partitiom::update_row() calls >> handler::write_row() in this case and must provide a complete record.
>
> In this case you don't need to clone at all. As I wrote above "in
> any case all the above can be skipped if the necessary bit is already
> set". That is, partition handler needs the complete record, so it sets
> all bits in read_set.
It doesn't do it yet. Thus Bug#26827. Isn't it too inefficient to read all columns, just because two of a million records need to change the partition? In all other cases the reduced read_set is sufficient for the update. Wasn't it for efficiency that read_set is not always complete for update?
If you think it's ok for the partition handler to always read complete records, I could copy Sergeys CSV change to partition. That would make a quick fix for Bug#26827.
Regards
Ingo
-- Ingo Strüwing, Senior Software Developer MySQL GmbH, Radlkoferstr. 2, D-81373 München Geschäftsführer: Kaj Arnö - HRB München 162140 -- MySQL Code Commits Mailing List For list archives: http://lists.mysql.com/commits To unsubscribe: http://lists.mysql.com/commits?unsub=lists@pantek.comReceived on Fri Jun 22 05:40:03 2007
This archive was generated by hypermail 2.1.8 : Fri Jun 22 2007 - 05:50:01 EDT
|
Contact Us Legal Notices Order Services Online Pantek Home Privacy Policy IT news Site Map Pantek Library |