PHP mysqlnd svn commit: r482 - in trunk: php5/ext/mysqli php6/ext/mysqli
Author: ahristov
Date: 2007-06-25 19:38:32 +0200 (Mon, 25 Jun 2007)
New Revision: 482
Modified:
trunk/php5/ext/mysqli/mysqli.c
trunk/php5/ext/mysqli/mysqli_api.c
trunk/php6/ext/mysqli/mysqli.c
trunk/php6/ext/mysqli/mysqli_api.c
Log:
Fix leaks mysqli/libmysql
Modified: trunk/php5/ext/mysqli/mysqli.c
- trunk/php5/ext/mysqli/mysqli.c 2007-06-25 17:35:08 UTC (rev 481)
+++ trunk/php5/ext/mysqli/mysqli.c 2007-06-25 17:38:32 UTC (rev 482)
@@ -1146,7 +1146,10 @@
#if !defined(HAVE_MYSQLND)
mysql_set_local_infile_handler(mysql->mysql, &php_local_infile_init, &php_local_infile_read,
&php_local_infile_end, &php_local_infile_error, (void *)mysql);
- mysql->li_read = NULL;
+ if (mysql->li_read) {
+ zval_ptr_dtor(&mysql->li_read);
+ mysql->li_read = NULL;
+ }
#else
mysqlnd_local_infile_default(mysql->mysql, TRUE);
#endif
Modified: trunk/php5/ext/mysqli/mysqli_api.c
- trunk/php5/ext/mysqli/mysqli_api.c 2007-06-25 17:35:08 UTC (rev 481)
+++ trunk/php5/ext/mysqli/mysqli_api.c 2007-06-25 17:38:32 UTC (rev 482)
@@ -1359,8 +1359,12 @@
/* save callback function */
#if !defined(HAVE_MYSQLND)
- ALLOC_ZVAL(mysql->li_read);
- ZVAL_STRING(mysql->li_read, callback_func->value.str.val, 1);
+ if (!mysql->li_read) {
+ MAKE_STD_ZVAL(mysql->li_read);
+ } else {
+ zval_dtor(mysql->li_read);
+ }
+ ZVAL_STRINGL(mysql->li_read, Z_STRVAL_P(callback_func), Z_STRLEN_P(callback_func), 1);
#else
mysqlnd_set_local_infile_handler(mysql->mysql, callback_func->value.str.val);
#endif
Modified: trunk/php6/ext/mysqli/mysqli.c
- trunk/php6/ext/mysqli/mysqli.c 2007-06-25 17:35:08 UTC (rev 481)
+++ trunk/php6/ext/mysqli/mysqli.c 2007-06-25 17:38:32 UTC (rev 482)
@@ -1177,7 +1177,10 @@
#if !defined(HAVE_MYSQLND)
mysql_set_local_infile_handler(mysql->mysql, &php_local_infile_init, &php_local_infile_read,
&php_local_infile_end, &php_local_infile_error, (void *)mysql);
- mysql->li_read = NULL;
+ if (mysql->li_read) {
+ zval_ptr_dtor(&mysql->li_read);
+ mysql->li_read = NULL;
+ }
#else
mysqlnd_local_infile_default(mysql->mysql, TRUE);
#endif
Modified: trunk/php6/ext/mysqli/mysqli_api.c
- trunk/php6/ext/mysqli/mysqli_api.c 2007-06-25 17:35:08 UTC (rev 481)
+++ trunk/php6/ext/mysqli/mysqli_api.c 2007-06-25 17:38:32 UTC (rev 482)
@@ -1395,8 +1395,12 @@
/* save callback function */
#if !defined(HAVE_MYSQLND)
- ALLOC_ZVAL(mysql->li_read);
- ZVAL_STRING(mysql->li_read, callback_func->value.str.val, 1);
+ if (!mysql->li_read) {
+ MAKE_STD_ZVAL(mysql->li_read);
+ } else {
+ zval_dtor(mysql->li_read);
+ }
+ ZVAL_STRINGL(mysql->li_read, Z_STRVAL_P(callback_func), Z_STRLEN_P(callback_func), 1);
#else
mysqlnd_set_local_infile_handler(mysql->mysql, callback_func->value.str.val);
#endif
--
MySQL Code Commits Mailing List
For list archives:
http://lists.mysql.com/commits
To unsubscribe:
http://lists.mysql.com/commits?unsub=lists@pantek.com
Received on Mon Jun 25 13:38:59 2007
This archive was generated by hypermail 2.1.8
: Mon Jun 25 2007 - 13:40:03 EDT
|