Re: bk commit into 5.0 tree (tnurnberg:1.2476) BUG#15327

Tatjana, Serg,

On 09 August 2007, Sergei Golubchik <serg@mysql.com> wrote:
> That's 49K - a bit too many for a change that only needs a few
> lines of changes.

I don't agree with this. The vast majority of those lines are because the my_long_options array had to be defined before main() in order for mysql_client_port_setup() to poke the correct default value in there. And that's needed in order to provide the correct information in --help.

Aside from moving that array, the patch just inserts a call to mysql_client_port_setup() near the top of main() - simple enough.

> And it doesn't fix scripts. By default they will use 3306 but the server
> will use the value from /etc/services.

This is already a problem, and I suggested to Tatjana that it be covered under a separate bug. Maybe I'm missing something, but I don't think this patch makes this problem worse.

Timothy

-- 
-- Timothy Smith       Team Lead, Maintenance; Dolores, Colorado, USA
-- MySQL, www.mysql.com      The best DATABASE COMPANY in the GALAXY!

-- 
MySQL Code Commits Mailing List
For list archives: 
http://lists.mysql.com/commits
To unsubscribe:    
http://lists.mysql.com/commits?unsub=lists@pantek.com