Re: bk commit into 5.1 tree (davi:1.2612) BUG#21136

• Davi Arnaut <davi@mysql.com> [07/09/28 23:24]:
  > ChangeSet@1.2612, 2007-09-28 16:22:46-03:00, davi@moksha.local +3 -0
  > Bug#21136 CREATE TABLE SELECT within CREATE TABLE SELECT causes server crash
  

OK to push.

Please see one item below.

> + if (create_info->options & HA_LEX_CREATE_TMP_TABLE)
> + m_plock= &m_lock, m_lock= extra_lock;

Please do two separate assignments on separate lines, as per the coding style.

> + else
> + m_plock= &thd->extra_lock, thd->extra_lock= extra_lock;

Same here.

If you want to save space you can do:

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.mysql.com Links announce benchmarks bugs certification cluster commits dotnet gui-tools internals java maxdb myodbc mysql mysqldoc packagers perl plusplus replication win32 Request more information about Pantek

if (create_info->options & HA_LEX_CREATE_TMP_TABLE)   m_plock= &m_lock;
else
  m_ploc= &thd->extra_lock;

*m_plock= extra_lock;

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY

-- 
MySQL Code Commits Mailing List
For list archives: 
http://lists.mysql.com/commits
To unsubscribe:    
http://lists.mysql.com/commits?unsub=lists@pantek.com