Re: Bug: char[]s not escaped

On 02/07/07, Andrew Sayers <andrew-mysqlpp@pileofstuff.org> wrote:
>
> +inline std::ostream& operator <<(quote_type1 o,
> + char in[])
> +{
> + return operator <<(o, static_cast<const char* const&>(in));
> +}

Personally I would use simply static_cast<cont char*>(in) if doing that.

It is a direct conversion from char[] to char* and last time I saw any benchmarks it was cheaper to copy a pointer a reference (and it will be copied by value when passed to the operator<< function anyway.) The assembly code shows five instructions for the reference version and two otherwise.

Alternatively, something like

template <int N>
inline std::ostream& operator <<(quote_type1 o, const char (&in)[N]) {

       return o.ostr->write(in, N-1); // don't write nul terminator }

You know the size of the array, why discard that info and require a strlen call? The const overloads aren't needed, char[N] will match const char[N] rather than the default specialisation, so you only need one overload for quote_type1 and one for escape_type1.

Jon

-- 
MySQL++ Mailing List
For list archives: 
http://lists.mysql.com/plusplus
To unsubscribe:    
http://lists.mysql.com/plusplus?unsub=lists@pantek.com

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related lists.mysql.com Links announce benchmarks bugs certification cluster commits dotnet gui-tools internals java maxdb myodbc mysql mysqldoc packagers perl plusplus replication win32 Request more information about Pantek