Hosting Provided By

kernel/3081: DLINK DFE580TX driver broken, VLAN problem + other stuff

From: box <box(at)xbsd.dk>
Date: Tue Feb 04 2003 - 15:30:27 EST

>Number: 3081
>Category: kernel
>Synopsis: DLINK DFE580TX driver broken, VLAN problem + other stuff
>Confidential: no
net
>Environment:

	System      : OpenBSD 3.1
	Architecture: OpenBSD.i386
	Machine     : i386

>Description:

Either the driver, or the hardware sucks... really sucks. The DLINK 570TX was an ok NIC, but this is really bad.

But here goes:

	VLAN not supported, see patch.
	Multicast not supported, see patch, not a good solution, but the MAC is programmed incorrectly I think (ipv6 multicast mac addresses??)
	Two PHY's found per interface, but why?
	Keep getting underrun errors, see patch. Not good enough but gets you going.
	Changing MTU not supported, see patch

>How-To-Repeat:

	Basic usage of the NIC should be more than enough :-), But full speed (FTP) transfers should trigger underruns.
	ifconfig ste0 mtu 1400 should trigger setting mtu not possible.
	Trying to run OSPF with this NIC is impossible due to the multicast bug.

>Fix:

Below is the patch I use to get things going, all of it might not be good, it gets me going.

"Fixes" multicast filters as well, but it's not the rigth solution, but i think that the problem with the filters is that only ipv6 mac address's are programmed into the MAC.

The threshhold code has been modified as well, speeds things up a bit... not nescecarilly good!

"Fixes" the why two phy's per MAC? problem...

if_ste.c.org Sun Dec 1 15:38:34 2002 +++ if_ste.c Sun Dec 1 16:11:56 2002 @@ -34,6 +34,7 @@ */

#include "bpfilter.h"
+#include "vlan.h"

#include <sys/param.h>
#include <sys/systm.h>
@@ -60,6 +61,11 @@

#include <net/if_media.h>

+#if NVLAN > 0
+#include 
+#include 
+#endif
+
 #if NBPFILTER > 0

#include <net/bpf.h>
#endif
@@ -334,6 +340,9 @@
{

 	struct ste_softc	*sc = (struct ste_softc *)self;
 	struct ste_mii_frame	frame;
+	
+	if ( sc->ste_one_phy && phy != 0 )
+		return (0);
 
 	bzero((char *)&frame, sizeof(frame));
 
@@ -531,6 +540,7 @@
 	if (ifp->if_flags & IFF_ALLMULTI || ifp->if_flags & IFF_PROMISC) {
 		STE_SETBIT1(sc, STE_RX_MODE, STE_RXMODE_ALLMULTI);
 		STE_CLRBIT1(sc, STE_RX_MODE, STE_RXMODE_MULTIHASH);
+		STE_CLRBIT1(sc, STE_RX_MODE, STE_RXMODE_ALLIPMULTI);
 		return;
 	}
 
@@ -553,6 +563,7 @@
 	CSR_WRITE_4(sc, STE_MAR1, hashes[1]);
 	STE_CLRBIT1(sc, STE_RX_MODE, STE_RXMODE_ALLMULTI);
 	STE_SETBIT1(sc, STE_RX_MODE, STE_RXMODE_MULTIHASH);
+	STE_SETBIT1(sc, STE_RX_MODE, STE_RXMODE_ALLIPMULTI);
 
 	return;

}
@@ -733,7 +744,7 @@

 			if (txstat & STE_TXSTATUS_UNDERRUN &&
 			    sc->ste_tx_thresh < STE_PACKET_SIZE) {
-				sc->ste_tx_thresh += STE_MIN_FRAMELEN;
+				sc->ste_tx_thresh += (4 * STE_MIN_FRAMELEN);
 				printf("ste%d: tx underrun, increasing tx"
 				    " start threshold to %d bytes\n",
 				    sc->ste_unit, sc->ste_tx_thresh);
@@ -871,6 +882,10 @@
 	s = splimp();
Do you need more help? 
In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software:Learn more about Pantek's Technical Support offerings
Place an order for 24/7/365 Technical Support here
Learn more about Pantek, who we are, and what we do
Chat with a Live Operator
Related openbsd.org Links
advocacy
announce
bugs
ipv6
misc
ports
ports-changes
security-announce
smp
source-changes
tech
Request more information about Pantek
 	sc->ste_unit = sc->sc_dev.dv_unit;
 
+	/* If RevisionID = 0x12 it's a DLINK 580TX and we should only probe one PHY */
+	if ((pci_conf_read(pc, pa->pa_tag, STE_PCI_REVISION_ID) & 0x000000FF) == 0x12) 
+		sc->ste_one_phy = 1;
+
 	/*
 	 * Handle power management nonsense.
 	 */
@@ -988,6 +1003,10 @@
 	IFQ_SET_READY(&ifp->if_snd);
 	bcopy(sc->sc_dev.dv_xname, ifp->if_xname, IFNAMSIZ);
 
+#if NVLAN > 0
+	ifp->if_capabilities |= IFCAP_VLAN_MTU;

+#endif
+

 	sc->sc_mii.mii_ifp = ifp;
 	sc->sc_mii.mii_readreg = ste_miibus_readreg;
 	sc->sc_mii.mii_writereg = ste_miibus_writereg;
@@ -1001,6 +1020,8 @@
 	} else
 		ifmedia_set(&sc->sc_mii.mii_media, IFM_ETHER|IFM_AUTO);
 
+	sc->ste_tx_thresh = 240;
+
 	/*
 	 * Call MI attach routines.
 	 */
@@ -1047,7 +1068,7 @@
 	c->ste_mbuf = m_new;
 	c->ste_ptr->ste_status = 0;
 	c->ste_ptr->ste_frag.ste_addr = vtophys(mtod(m_new, caddr_t));
-	c->ste_ptr->ste_frag.ste_len = 1536 | STE_FRAG_LAST;
+	c->ste_ptr->ste_frag.ste_len = (1536 + EVL_ENCAPLEN) | STE_FRAG_LAST;
 
 	return(0);

}

@@ -1212,6 +1233,9 @@
 	CSR_WRITE_2(sc, STE_ISR, 0xFFFF);
 	CSR_WRITE_2(sc, STE_IMR, STE_INTRS);
 
+	/* Accept VLAN length packets */
+	CSR_WRITE_2(sc, STE_MAX_FRAMELEN, ETHER_MAX_LEN + EVL_ENCAPLEN);
+
 	ste_ifmedia_upd(ifp);
 
 	ifp->if_flags |= IFF_RUNNING;
@@ -1343,6 +1367,13 @@
 		sc->ste_if_flags = ifp->if_flags;
 		error = 0;
 		break;
+	case SIOCSIFMTU:
+		if(ifr->ifr_mtu > ETHERMTU || ifr->ifr_mtu < ETHERMIN) {
+			error = EINVAL;
+		} else if (ifp->if_mtu != ifr->ifr_mtu) {
+			ifp->if_mtu = ifr->ifr_mtu;
+		}
+ 		break; 
 	case SIOCADDMULTI:
 	case SIOCDELMULTI:
 		error = (command == SIOCADDMULTI) ?
@@ -1466,7 +1497,7 @@
 	sc->ste_cdata.ste_tx_prod = idx;
 	start_tx->ste_prev->ste_ptr->ste_next = start_tx->ste_phys;
 
-	ifp->if_timer = 5;
+	ifp->if_timer = 10;
 
 	return;
 }
--- if_stereg.h.org	Sun Dec  1 15:38:24 2002
Can we help you? 
In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software:Learn more about Pantek's Technical Support offerings
Place an order for 24/7/365 Technical Support here
Learn more about Pantek, who we are, and what we do
Chat with a Live Operator
Related openbsd.org Links
advocacy
announce
bugs
ipv6
misc
ports
ports-changes
security-announce
smp
source-changes
tech
Request more information about Pantek
+++ if_stereg.h	Sun Dec  1 15:39:46 2002
@@ -353,6 +353,7 @@
 #define STE_PCI_DEVICE_ID		0x02
 #define STE_PCI_COMMAND			0x04
 #define STE_PCI_STATUS			0x06
+#define STE_PCI_REVISION_ID		0x08
 #define STE_PCI_CLASSCODE		0x09
 #define STE_PCI_LATENCY_TIMER		0x0D
 #define STE_PCI_HEADER_TYPE		0x0E
@@ -514,6 +515,7 @@
 	struct ste_list_data	*ste_ldata;
 	caddr_t			ste_ldata_ptr;
 	struct ste_chain_data	ste_cdata;
+	u_int8_t		ste_one_phy;

};

Do you need help?

struct ste_mii_frame {

>Release-Note:
Received on Fri Feb 7 11:29:51 2003

This message: [ Message body ]
Next message: David Krause: "share/dict/propernames patch"
Previous message: Arne Woerner: "system/3084: lprm / rmremove still funny..."
In reply to grubba(at)pike.ida.liu.se: "alpha/3083: /usr/lib/crtbegin.o uses BRADDR relocations from .fini to .text"
Reply: Chris Pascoe: "only one ether driver has hardware VLAN support enabled?"
Reply: John L. Scarfone: "Re: system/3252: at command seems to always send mail"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]

This archive was generated by hypermail 2.1.8 : Wed Aug 23 2006 - 13:29:50 EDT