system/3193: non correct pwd_mkdb call in src/etc/Makefile

From: <cjeker(at)diavolezza.pipeline.ch>
Date: Thu Apr 10 2003 - 10:32:30 EDT

>Number: 3193
>Category: system
>Synopsis: non correct pwd_mkdb call in src/etc/Makefile
>Confidential: yes
        

	System      : OpenBSD 3.3
	Architecture: OpenBSD.i386
	Machine     : i386

>Description:
        

	The Makefile in /usr/src/etc does not respect the ${DESTDIR}
	env while creating the passwd databases.
	The pwd_mkdb uses /etc/master.passwd as input instead of 
	${DESTDIR}/etc/master.passwd. Because of this it is possible that
	the pwd.db and spwd.db contain additional user information.

>How-To-Repeat:
        

>Fix:
        

	This patch should fix the problem but then ${DESTDIR} has to be 
	absolute:
diff -u -r1.181 Makefile
--- Makefile    24 Mar 2003 18:15:27 -0000      1.181

+++ Makefile 10 Apr 2003 14:07:32 -0000 @@ -75,7 +75,7 @@

        ${INSTALL} -c -o root -g wheel -m 600 crontab ${DESTDIR}/var/cron/tabs/root
        ${INSTALL} -c -o root -g wheel -m 644 login.conf ${DESTDIR}/etc
        ${INSTALL} -c -o root -g wheel -m 600 master.passwd ${DESTDIR}/etc
-       pwd_mkdb -p -d ${DESTDIR}/etc /etc/master.passwd
+       pwd_mkdb -p -d ${DESTDIR}/etc ${DESTDIR}/etc/master.passwd
        ${INSTALL} -c -o root -g wheel -m 644 moduli ${DESTDIR}/etc
        ${INSTALL} -c -o root -g wheel -m 600 pf.conf ${DESTDIR}/etc
        ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 555 \

>Release-Note:
Received on Thu Apr 10 10:47:13 2003