user/3199: isakmpd does not unlink FIFO nor pid file

From: <andre(at)inet2.it>
Date: Fri Apr 11 2003 - 10:29:19 EDT

>Number: 3199
>Category: user
>Synopsis: isakmpd does not unlink FIFO nor pid file
>Confidential: no
net
>Environment:
        

	System      : OpenBSD 3.2
	Architecture: OpenBSD.i386
	Machine     : i386

>Description:

If you send a SIGTERM to isakmpd (or even do echo Q > /var/run/isakmpd.fifo) isakmpd closes in a clean way, but it does not unlink FIFO, nor pid file. It is not good! I'm writing some PHP code to configure isamkpd and if it is not running the code hangs up waiting for a reader to read from the FIFO.

I checked even 3.3 isakmpd, but seems to have the same problem.

>How-To-Repeat:
        

>Fix:

        here is a little patch, against v 1.45. It should work even on 1.48 (that is OpenBSD 3.3 version).

• isakmpd.c.orig Fri Apr 11 16:27:08 2003 +++ isakmpd.c Fri Apr 11 16:27:15 2003 @@ -298,6 +298,10 @@ sigtermed++; }

+       log_print ("isakmpd: unlinking fifo...");
+       unlink (ui_fifo);
+       log_print ("isakmpd: unlinking pid file...");
+       unlink (pid_file);
   if (transport_prio_sendqs_empty ())
     {
       /*
@@ -425,7 +429,7 @@
        * value, and the daemon exits.
        */
       if (sigtermed)
-       daemon_shutdown ();
+                               daemon_shutdown ();
 
       /* Setup the descriptors to look for incoming messages at.  */
       memset (rfds, 0, mask_size);

>Release-Note:
Received on Fri Apr 11 10:46:33 2003