Re: user/3228: Arla is broken after string clean

From: Jan Johansson <janj+openbsd(at)wenf.org>
Date: Tue Apr 22 2003 - 10:55:02 EDT

The following reply was made to PR user/3228; it has been noted by GNATS.

From: Jan Johansson <janj+openbsd@wenf.org> To: gnats@openbsd.org
Cc:
Subject: Re: user/3228: Arla is broken after string clean Date: Tue, 22 Apr 2003 16:41:42 +0200

 Changing between 1.2 and 1.3 of fdir.c make the problem come and  go.  

 Index: fdir.c

---

 RCS file: /cvs/src/usr.sbin/afs/src/lib/bufdir/fdir.c,v  retrieving revision 1.2
 retrieving revision 1.3
 diff -u -r1.2 -r1.3

• fdir.c 2002/06/07 04:38:03 1.2 +++ fdir.c 2003/04/06 19:09:04 1.3 @@ -287,7 +287,7 @@ page->entry[i].next = next; page->entry[i].fid.Vnode = htonl(fid.Vnode); page->entry[i].fid.Unique = htonl(fid.Unique);
  • strcpy (page->entry[i].name, filename); + strlcpy (page->entry[i].name, filename, sizeof(page->entry[i].name)); memset(page->entry[i + j - 1].fill, 0, 4); if (pageno < MAXPAGES) page0->dheader.map[pageno] -= n;

Received on Tue Apr 22 10:55:38 2003