Re: Update: fvwm-2.5.5

From: J.A. Neitzel <jneitzel(at)sdf.lonestar.org>
Date: Mon Dec 30 2002 - 17:38:24 EST

Well, as for fvwm-2.5.5 vs. fvwm-2.4.14 ..? I've used both and have found that 2.5.5 simply works better.

Actually, 2.4.1[23] worked better than 2.4.14 for me. It appears that 2.4.14 has a bug or two in FvwmIconMan..? However, this does not appear to be an issue in 2.5.5; since 2.5.5 has features I wanted anyway I go with it over 2.4.x .

NOTES:
There is a 'tempnam()' warning for fvwm/session.c(line 232). I don't know if it's an issue since it uses HOME as the *tmpdir ..? Also:
FvwmCpp.c:255: warning: mktemp()
FvwmM4.c:297: warning: mktemp()

There are still some perl-related files which get installed. Perhaps they should be removed from PLIST* since you are doing '--disable-perllib'. Also, you use the '--enable-extras' configure switch. Does this do anything useful..? I ask because it is not mentioned in the output from '--help' _or_ in the file 'INSTALL.fvwm'.

It seems your update had some PLIST issues. It also wants to use -lintl but appears to need "-I${LOCALBASE}/include" in CPPFLAGS . Also, should this not require MODULES=gettext ?

I notice during configure with your update that it gave WARNING about missing iconv()... Based on this and the above mentioned PLIST issues I made changes which are reflected in the appended patch. It is diffed against your update.

I removed my old install of 2.5.5 and replace it with this update to your update. I successfully built, installed, and am currently running fine with it on:

	Last cvs update on 2002-12-26 @ 07:15 MST
	OpenBSD 3.2-current (GENERIC) #0: Thu Dec 26 13:34:29 EST 2002

===================================================================
diff -uNr --exclude=CVS ../fvwm2.orig/Makefile ./Makefile
--- ../fvwm2.orig/Makefile	Mon Dec 30 11:15:42 2002

+++ ./Makefile	Mon Dec 30 15:25:26 2002


@@ -57,12 +57,15 @@
 SUBST_VARS=	VERSION
 
 USE_X11=	Yes
-


+MODULES=	gettext

 SEPARATE_BUILD= concurrent

 CONFIGURE_STYLE= gnu
-CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include/libpng" \


+CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include \

+				-I${LOCALBASE}/include/libpng" \


 		LDFLAGS="-L${LOCALBASE}/lib"

-CONFIGURE_ARGS+=--with-intl-library="${LOCALBASE}/lib" \
+CONFIGURE_ARGS+=--with-iconv-library="${LOCALBASE}/lib" \
+ --with-iconv-includes="${LOCALBASE}/include" \
+ --with-intl-library="${LOCALBASE}/lib" \

 		--with-intl-includes="${LOCALBASE}/include" \
 		--with-png-library="${LOCALBASE}/lib" \
 		--with-png-includes="${LOCALBASE}/include/libpng" \
diff -uNr --exclude=CVS ../fvwm2.orig/pkg/PLIST-fvwm2 ./pkg/PLIST-fvwm2
--- ../fvwm2.orig/pkg/PLIST-fvwm2	Wed Feb  6 14:39:26 2002


+++ ./pkg/PLIST-fvwm2	Mon Dec 30 14:59:11 2002

@@ -1,14 +1,18 @@

 @comment $OpenBSD: PLIST-fvwm2,v 1.4 2002/02/06 19:39:26 pvalchev Exp $  @pkgcfl fvwm2+fvicons-*
 bin/FvwmCommand
+@comment bin/fvwm

 bin/fvwm-config


+bin/fvwm-convert-2.4


+bin/fvwm-convert-2.6


 bin/fvwm-menu-desktop
 bin/fvwm-menu-directory
 bin/fvwm-menu-headlines
 bin/fvwm-menu-xlock

+bin/fvwm-perllib


 bin/fvwm2
-bin/fvwm24_convert
-bin/fvwmbug
 bin/xpmroot
 libexec/fvwm/${VERSION}/FvwmAnimate
 libexec/fvwm/${VERSION}/FvwmAudio
@@ -59,11 +63,14 @@
 man/man1/FvwmEvent.1
 man/man1/FvwmForm.1
 man/man1/FvwmGtk.1

+man/man1/FvwmGtkDebug.1


 man/man1/FvwmIconBox.1
 man/man1/FvwmIconMan.1
 man/man1/FvwmIdent.1
 man/man1/FvwmM4.1
 man/man1/FvwmPager.1

+man/man1/FvwmPerl.1


 man/man1/FvwmRearrange.1

 man/man1/FvwmSave.1
 man/man1/FvwmSaveDesk.1
@@ -73,15 +80,20 @@

 man/man1/FvwmTheme.1
 man/man1/FvwmWharf.1
 man/man1/FvwmWinList.1

+man/man1/FvwmWindowLister.1


 man/man1/fvwm-config.1

+man/man1/fvwm-convert-2.2.1


 man/man1/fvwm-menu-desktop.1
 man/man1/fvwm-menu-directory.1
 man/man1/fvwm-menu-headlines.1
 man/man1/fvwm-menu-xlock.1

+man/man1/fvwm-perllib.1

 man/man1/fvwm2.1
-man/man1/fvwm24_convert.1
-man/man1/fvwmbug.1
-man/man1/fvwmrc_convert.1
 man/man1/xpmroot.1

 share/fvwm/ConfigFvwmBacker
 share/fvwm/ConfigFvwmButtons Received on Mon Dec 30 17:41:03 2002