Re: 2 new ports: LinPopUp and CDK

On Fri, Mar 14, 2003 at 08:55:06AM +0000, Jorge Cortes wrote:
> http://www.openbsd.org.mx/~jcortes/ports/LinPopUp-1.2.0.tgz

I highly recommended adding:

PKGNAME= ${DISTNAME:L} I think HOMEPAGE should be http://www.littleigloo.org/software_002.php3.

Put # GPL above the PERMIT_* lines.

It doesn't respect CFLAGS or CC.

This definitely needs to be fixed, as pvalchev@ just went through the tree fixing them all:

execute.c: In function `execute_program':
execute.c:46: warning: couldn't find null pointer sentinel value starting at 2
execute.c:46: warning: (integer 0 is not a null pointer in varargs context)

This should probably be fixed too:

Do you need help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related openbsd.org Links advocacy announce bugs ipv6 misc ports ports-changes security-announce smp source-changes tech Request more information about Pantek

send.o: In function `send_send':
send.o(.text+0x690): warning: tmpnam() possibly used unsafely; consider using mkstemp()

I noticed that the files are dated 3 years ago.. is this no longer actively maintained? :(

> http://www.openbsd.org.mx/~jcortes/ports/cdk-4.9.10.tgz

DISTNAME= cdk

This is bad. When they release a new version, the checksum will fail. You should try to get them to version the distfile, or mirror a versioned copy of the distfile somewhere.

No comment above PERMIT_* lines. It *looks* like a BSD-style license.

Doesn't respect CC.

This also looks like it isn't actively maintained :( Maybe DISTNAME won't be a problem then... :P

Do you need more help?

In addition to our free technical library, Pantek provides professional IT services to companies who utilize Open Source software: Learn more about Pantek's Technical Support offerings Place an order for 24/7/365 Technical Support here Learn more about Pantek, who we are, and what we do Chat with a Live Operator Related openbsd.org Links advocacy announce bugs ipv6 misc ports ports-changes security-announce smp source-changes tech Request more information about Pantek

I'm not sure if installing all the example program source in share/examples is needed (or desired).

• jolan