Re: copyin problem

On Tue, 29 Apr 2003, Jean-Francois Brousseau wrote:

> > pdacioctl(dev, cmd, data, flags, p)
> > dev_t dev;
> > caddr_t data;
> > int flags;
> > {
> > struct data_io *scan_struct1,*c;
> > c=(struct data_io *)data;
> > error=copyin(c,scan_struct1,sizeof(struct data_io));
>
> Your 'scan_struct1' should not be a pointer to a 'struct data_io',

then you have to pass the address. but that's not typically used for ioctl. the ioctl syscall already copies in data. data is likely a pointer into kernel space, don't use copyin on it. see sys_generic.c for sys_ioctl() and the magic.

--
"I am making this trip to Africa because Washington is an international
city, just like Tokyo, Nigeria or Israel.  As mayor, I am an
international symbol.  Can you deny that to Africa?"
      - M. Barry, Mayor of Washington, DC